Re: [PATCH 2/2] xdiff: implement empty line chunk heuristic

From: Stefan Beller <sbeller@google.com>
Date: Apr 15, 2016, 23:45 UTC
Message-ID: <CAGZ79kbja85_wMVZwy9i--8F0e=iboaZuOjgbhMmF+8xuks7mA@mail.gmail.com>
In-Reply-To: <CA+P7+xoMVzYwWv3=7hTUM7gMjm4i7Vv74aoyw17T_CbToZTVaA@mail.gmail.com>

On Fri, Apr 15, 2016 at 4:32 PM, Jacob Keller <jacob.keller@gmail.com> wrote:

Show 16 quoted lines

> On Fri, Apr 15, 2016 at 4:05 PM, Jacob Keller <jacob.keller@gmail.com> wrote:
>> There's a few places that will need cleaning up (comments and such)
>> that mention empty line still, but that's not surprising. I am going
>> to test this for a bit on my local repos, and see if it makes any
>> difference to the old heuristic as well.
>>
>> Thanks,
>> Jake
>>
>
> I ran this heuristic on git.git and it produces tons of false positive
> transforms which are much lease readable (to me at least), far more
> than those produced by the newline/blank link heuristic did.
>
> I think we should stick with the empty line heuristic instead of this
> version, even if it's easier to implement this version.

I agree. The heuristic is worse as we often have these 50:50 chances of messing stuff up.

Show 6 quoted lines

>
> We still would need to figure out how to handle CRLF properly but it's
> worth resolving that than this heuristic is.
>
> Thanks,
> Jake