Re: What's cooking in git.git (Oct 2018, #05; Fri, 26)
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 26, 2018, 19:04 UTC
- Message-ID
- <CAGZ79kbjKZSHfHbDykkob1w21RTB9tgCCYVrOD=0C8aAFGncTQ@mail.gmail.com>
- In-Reply-To
- <xmqqo9bhcf89.fsf@gitster-ct.c.googlers.com>
Show 10 quoted lines
> > * sb/strbuf-h-update (2018-09-29) 1 commit > (merged to 'next' on 2018-10-26 at e4ad935cb0) > + strbuf.h: format according to coding guidelines > > Code clean-up to serve as a BCP example. > > Will merge to 'master'. > Further clean-up patches may need to follow soon before this > change escapes to 'master'.
We have a contradicting statement here, which can be either an issue or an oversight.
In [1] I stated that I dislike the style that was proposed (which I understood as these "further cleanup patches" you speak of above), I do not recall other cleanups to be needed.
[1] https://public-inbox.org/git/CAGZ79kZGEMWpr7aqeqXbC4bkmsCCiW+1pxbEV4T0vfsYG+_3iA@mail.gmail.com/