Re: What's cooking in git.git (Sep 2017, #06; Fri, 29)

From: Stefan Beller <sbeller@google.com>
Date: Sep 29, 2017, 17:27 UTC
Message-ID: <CAGZ79kbh1kELT5nOJHAg8yZ-zp7vcxnxAGzXZ1nSPSX0qJoOrA@mail.gmail.com>
In-Reply-To: <5f7dbd81-ae27-c3a2-a14d-2832f71db1e9@gmail.com>

On Fri, Sep 29, 2017 at 6:08 AM, Derrick Stolee <stolee@gmail.com> wrote:

Show 19 quoted lines

> Hi Junio,
>
> On 9/29/2017 12:34 AM, Junio C Hamano wrote:
>>
>> * ds/find-unique-abbrev-optim (2017-09-19) 4 commits
>>   - SQUASH???
>>   - sha1_name: parse less while finding common prefix
>>   - sha1_name: unroll len loop in find_unique_abbrev_r()
>>   - sha1_name: create perf test for find_unique_abbrev()
>
>
> I'll re-roll my patch on Monday if reviews have stabilized. I think I
> understand your comments this time (especially around 32-bit ints).
> Since I'm new to the list, I'm not sure what the change in messages
> means here.
>
> What does "SQUASH???" mean? Is that why there are three meaningful commits
> in this note, despite my five-commit patch? Would you like me to squash the
> commits in v3?

If you fetch from github/gitster/git, there is a branch 'ds/find-unique-abbrev-optim' containing four commits; three by you, one by Junio. This one commit is titled 'SQUASH???' as Junio did not want to write out what the commit is doing (e.g. fixing a typo, a memleak, or indentation or other small detail that he observed)

You want to take the content of the commit and add it to one of yours, where appropriate.

>
> Thanks,
> -Stolee