git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule--helper: set alternateLocation for cloned submodules

From
Stefan Beller <sbeller@google.com>
Date
Dec 8, 2016, 18:04 UTC
Message-ID
<CAGZ79kbbi1J3BgQF-Ws0Ud-4h9efuQJTdsiA7Skh1fZXH5xqgg@mail.gmail.com>
In-Reply-To
<20161208174633.bsktiflql6jpn5t3@sigill.intra.peff.net>
On Thu, Dec 8, 2016 at 9:46 AM, Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
>
> will both trigger on the &&-chain linter, because it uses a magic exit
> code to detect the breakage. I think the problem is just that the
> &&-chain linter cannot peek inside subshells, and that's where the bug
> was in this case.

Uh, yeah in the subshell, but the patch v2 did have it not in subshells, I'll take another look.

>
> I wish we could improve that, but I spend a lot of brain cycles on it at
> one point and couldn't come up with a workable solution.

Is it possible to overwrite what happens when you open a subshell with ( ) ? i.e. I imagine in the global test-setup we'd setup that ( ) not just opens /bin/sh but a shell with benefits such that we can execute just one && chain.

Previous: Jeff KingNext: vi0oss
Message 4 of 7 in “submodule--helper: set alternateLocation for cloned submodules”
  1. submodule--helper: set alternateLocation for cloned submodulesvi0oss@gmail.com, Dec 8, 2016
  2. Stefan BellerDec 8, 2016
  3. Jeff KingDec 8, 2016
  4. Stefan BellerDec 8, 2016
  5. vi0ossDec 8, 2016
  6. Stefan BellerDec 8, 2016
  7. Jeff KingDec 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.