Re: [PATCH 00/13] object store: alloc

From: Stefan Beller <sbeller@google.com>
Date: May 7, 2018, 20:53 UTC
Message-ID: <CAGZ79kbb8KOTjAVSrxN2GhRmem_A9BdUmaHjM64UoDP3MfHqSQ@mail.gmail.com>
In-Reply-To: <xmqqo9hrpnn6.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Mon, May 7, 2018 at 7:05 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> This applies on top of sb/oid-object-info and is the logical continuum of
>> the series that it builds on; this brings the object store into more of
>> Gits code, removing global state, such that reasoning about the state of
>> the in-memory representation of the repository is easier.
>
> I am not sure how well this topic is done, but I've queued the
> following patch at the tip of the topic to make it compile after
> getting merged to integration branches (curiously, the topic by
> itself compiled file for whatever reason).

Thanks for the fixup; I will include it with other fixes in a reroll.

The investigation why it would not compile is not found in alloc.c but in 1da1580e4c2 (Makefile: detect compiler and enable more warnings in DEVELOPER=1, 2018-04-14), which enabled -Werror=missing-prototypes, that requires a prototype which is found in alloc.h

Thanks, Stefan