Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

From: Stefan Beller <sbeller@google.com>
Date: Aug 6, 2018, 18:19 UTC
Message-ID: <CAGZ79kbXtQP+Q+xCn5f6CO5Wk_3dbHeEVgny4jGnTwwW0j_LSw@mail.gmail.com>
In-Reply-To: <20180806125828.66fc99ef0b118e26e0b3e60d@ao2.it>

Show 12 quoted lines

> The consistency I was referring to is merely in the mechanism used to
> deal with .gitmodules: by always using "submodule--helper config".
>
> As a side argument: in some previous discussion Stefan mentioned the
> possibility that, in the future, he may be interested to explore
> different locations for submodules configuration, like a special ref,
> to prevent .gitmodules from being in the working tree at all, not even
> for writing submodule configuration.
>
> Having an opaque "stage submodule configuration" operation would
> prepare for that too, but as I said this is not my immediate goal.
>

Thanks for demonstrating that this will be easy to achieve in the future!

> Having said that I can drop patches 06/07 if this can help moving things
> forward; or if I had some success in convincing you I can improve the
> user interface (any advice?) and the commit message.
>

I think dropping the patches would be a good idea, given that this is not your immediate goal.

Thanks, Stefan