git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/5] [GSoC] remove_subtree(): reimplement using iterators

From
Stefan Beller <sbeller@google.com>
Date
Apr 13, 2017, 00:50 UTC
Message-ID
<CAGZ79kbTjVSRgWc5su89pL5t_mSEubjT_cQ0Onu4EdcKVmyL7w@mail.gmail.com>
In-Reply-To
<CAEA2_RJfcOc6FD41FNzU9LYs2xfzGZJxQyb2x8txuQqUE8RtNQ@mail.gmail.com>

On Wed, Apr 12, 2017 at 5:06 PM, Daniel Ferreira (theiostream) <bnmvco@gmail.com> wrote:

> Hey there! I'm sorry for bothering you, but any chance you might have
> overlooked this patch for a review?

Sort of. I read through them and found no issue back then, but did not reply anticipating someone else would .

>  (I'm just not familiar with how
> long patches usually take to be reviewed, and since I always got an
> answer within two days of sending it I wondered if you may have just
> not noticed it.)

I reviewed it again and found just a very minor nit, no need for a resend if that is the only nit.

Thanks, Stefan

Previous: Daniel Ferreira (theiostream)Next: Michael Haggerty
Message 10 of 11 in “[GSoC] remove_subtree(): reimplement using iterators”
  1. 0/5 [GSoC] remove_subtree(): reimplement using iteratorsDaniel Ferreira, Apr 6, 2017
  2. 1/5 dir_iterator: add tests for dir_iterator APIDaniel Ferreira, Apr 6, 2017
  3. Stefan BellerApr 13, 2017
  4. 2/5 remove_subtree(): test removing nested directoriesDaniel Ferreira, Apr 6, 2017
  5. 4/5 dir_iterator: refactor state machine modelDaniel Ferreira, Apr 6, 2017
  6. Michael HaggertyApr 17, 2017
  7. 3/5 dir_iterator: add helpers to dir_iterator_advanceDaniel Ferreira, Apr 6, 2017
  8. 5/5 remove_subtree(): reimplement using iteratorsDaniel Ferreira, Apr 6, 2017
  9. Daniel Ferreira (theiostream)Apr 13, 2017
  10. Stefan BellerApr 13, 2017
  11. Michael HaggertyApr 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.