One whitespace breaks sending mail (using mailrc aliases wit send-emal)
- From
Stefan Beller <sbeller@google.com>
- Date
- Mar 17, 2016, 01:28 UTC
- Message-ID
- <CAGZ79kbRdPMkbs_-BGhCQ44hOsccG3aX16RJpE3ZHcBmDz40zQ@mail.gmail.com>
To reproduce:
$ git config sendemail.aliasesfile ~/.mailrc $ git config sendemail.aliasfiletype mailrc $ echo "alias zzz_wrong_entry jon@do.e " # notice the white space at the end of the alias
$ git send-email 0001-rebase-x-do-not-die-without-i.patch --cc=zzz_wrong_entry Use of uninitialized value $alias in hash element at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 847. Use of uninitialized value $alias in hash element at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 850. Use of uninitialized value $alias in hash element at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 850. Use of uninitialized value $alias in hash element at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 850. Use of uninitialized value $alias in hash element at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 851. Use of uninitialized value $recipient in substitution (s///) at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 1036. Use of uninitialized value $recipient in pattern match (m//) at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 1038. Use of uninitialized value $address in pattern match (m//) at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 894. Use of uninitialized value $address in substitution (s///) at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 896. Use of uninitialized value $params[0] in pattern match (m//) at /usr/share/perl5/Email/Valid.pm line 79. Use of uninitialized value $address in concatenation (.) or string at /usr/local/google/home/sbeller/libexec/git-core/git-send-email line 918. error: unable to extract a valid address from: What to do with this address? ([q]uit|[d]rop|[e]dit):
The stack trace doesn't even show the wrong address, so debugging that was hard. Not sure I am asking for help, as I found the problem and could fix it, but maybe we can improve the error message (I have no knowledge about perl, so I may not be super helpful there)
Thanks, Stefan