Re: [PATCHv8 8/8] clone: recursive and reference option triggers submodule alternates

From: Stefan Beller <sbeller@google.com>
Date: Aug 18, 2016, 17:18 UTC
Message-ID: <CAGZ79kbRNG-BCs2vZAq5CWBNc2EYyaL7Ft-eTt2=H6GmP+aNfQ@mail.gmail.com>
In-Reply-To: <xmqqziob6ibv.fsf@gitster.mtv.corp.google.com>

On Wed, Aug 17, 2016 at 5:17 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>>  and now with error handling of invalid options.
>
> Thanks.

Well this was not the end of the story. I sent that version out, before doing a final test run, because changing a few lines is trivial right? :(

I'll resend with:

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index a1da3ea..a366757 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -562,7 +562,7 @@ static void prepare_possible_alternates(const char *sm_name,

        if (!strcmp(sm_alternate, "superproject"))
                foreach_alt_odb(add_possible_reference_from_superproject, &sas);
-       else if (!strcmp(sm_alternate, "no")
+       else if (!strcmp(sm_alternate, "no"))
                ; /* do nothing */
        else
                die(_("Value '%s' for submodule.alternateLocation is
not recognized"), sm_alternate);