git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/WIP 00/19] Kill the_index, final part

From
Stefan Beller <sbeller@google.com>
Date
Oct 19, 2018, 17:38 UTC
Message-ID
<CAGZ79kbQ_QLb_Oa3mg3q2FJUNoLkk_nzqoURHKY1U1i8iUSg4w@mail.gmail.com>
In-Reply-To
<20181019145237.16079-1-pclouds@gmail.com>
On Fri, Oct 19, 2018 at 7:52 AM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
Show 5 quoted lines
>
> Stefan I see you start removing more references of the_repository in
> another series (haven't really looked at it yet) so this is just heads
> up so we could coordinate if needed. Still WIP, not really ready for
> review yet.

I'll take a brief look anyway, otherwise you wouldn't have put in on a mailing list :-P

Yes, coordination would be good; stolee brought up a good point regarding testing these changes. Killing of the index in itself can be just tested by checking if behavior stays the same, but killing of the_repository is a slightly different beast, as it relates to submodules, which means any global state that is still around, need to go into the repository struct (we might have missed some there, whereas the index struct has been around for a long time).

Show 5 quoted lines
> This series removes use of the_index outside builtin/ and t/helper/.
> The only the_index reference left is in repository.c. The macro
> NO_THE_REPOSITORY_COMPATIBILITY_MACROS is now flipped to
> USE_THE_INDEX_COMPATIBILITY_MACROS. "the_index" is forbidden by
> default.
Wow, that is really cool. Looking forward for the patches. :-)
> After this I think we can start pushing the_repository outside library
> code. Then perhaps clean them up in builtin code too and you can
> finally get rid of it. But I don't think that'll happen in a year's
> time.
That sounds realistic.
Stefan
Previous: Nguyễn Thái Ngọc DuyNext: Duy Nguyen
Message 21 of 22 in “Kill the_index, final part”
  1. 00/19 Kill the_index, final partNguyễn Thái Ngọc Duy, Oct 19, 2018
  2. 01/19 wt-status.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  3. 02/19 wt-status.c: remove implicit dependency the_repositoryNguyễn Thái Ngọc Duy, Oct 19, 2018
  4. 03/19 list-objects-filter.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  5. 04/19 list-objects.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  6. 06/19 sequencer.c: remove implicit dependency on the_repositoryNguyễn Thái Ngọc Duy, Oct 19, 2018
  7. 05/19 sequencer.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  8. 08/19 notes-merge.c: remove implicit dependency the_repositoryNguyễn Thái Ngọc Duy, Oct 19, 2018
  9. 07/19 notes-merge.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  10. 09/19 repository.c: replace hold_locked_index() with repo_hold_locked_index()Nguyễn Thái Ngọc Duy, Oct 19, 2018
  11. 10/19 checkout: avoid the_index when possibleNguyễn Thái Ngọc Duy, Oct 19, 2018
  12. 12/19 read-cache.c: replace update_index_if_able with repo_&Nguyễn Thái Ngọc Duy, Oct 19, 2018
  13. 13/19 transport.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  14. 11/19 read-cache.c: kill read_index()Nguyễn Thái Ngọc Duy, Oct 19, 2018
  15. 14/19 sha1-name.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  16. 16/19 merge-recursive.c: remove implicit dependency on the_repositoryNguyễn Thái Ngọc Duy, Oct 19, 2018
  17. 15/19 merge-recursive.c: remove implicit dependency on the_indexNguyễn Thái Ngọc Duy, Oct 19, 2018
  18. 17/19 read-cache.c: remove the_* from index_has_changes()Nguyễn Thái Ngọc Duy, Oct 19, 2018
  19. 19/19 Flip NO_THE_REPOSITORY_COMPATIBILITY_MACROSNguyễn Thái Ngọc Duy, Oct 19, 2018
  20. 18/19 cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switchNguyễn Thái Ngọc Duy, Oct 19, 2018
  21. Stefan BellerOct 19, 2018
  22. Duy NguyenOct 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.