git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: do not allow reversing a 'copy' patch

From
Stefan Beller <sbeller@google.com>
Date
Feb 6, 2015, 23:39 UTC
Message-ID
<CAGZ79kbLGEmVWvDki9UefzX9zj8m+O9_nWH07WLxqTym4mptGg@mail.gmail.com>
In-Reply-To
<xmqqa90qd4iu.fsf@gitster.dls.corp.google.com>
On Fri, Feb 6, 2015 at 3:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> +                       die(_("sorry, cannot apply a 'copying' patch in reverse (yet)"));

Is it wise to give the reader of the output hope that this is not implemented (yet) but may be in the future?

I'd drop the "sorry" as well as the "(yet)" as the style of this error message seems to differ from other error messages in git.

Previous: Junio C Hamano
Message 4 of 4 in “[RFH] "diff -B -M"”
  1. Junio C HamanoFeb 6, 2015
  2. Junio C HamanoFeb 6, 2015
  3. apply: do not allow reversing a 'copy' patchJunio C Hamano, Feb 6, 2015
  4. Stefan BellerFeb 6, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.