Re: [PATCH 3/3] clone: add t5614 to test cloning submodules with shallowness involved

From: Stefan Beller <sbeller@google.com>
Date: Apr 25, 2016, 17:41 UTC
Message-ID: <CAGZ79kbL7VyimptOtOkrx=OvVw_Zdbfxq=J+JSUJXanFweYzNQ@mail.gmail.com>
In-Reply-To: <CA+P7+xppaK9d77h74j-4K=oWftdkeJE7048+PMzLS6gBS3E_uQ@mail.gmail.com>

On Tue, Apr 12, 2016 at 11:52 PM, Jacob Keller <jacob.keller@gmail.com> wrote:

Show 10 quoted lines

> On Tue, Apr 12, 2016 at 4:48 PM, Stefan Beller <sbeller@google.com> wrote:
>> There are some inherent issues with shallow clones and submodules, such
>> as having not having a commit available the superproject may point to
>> in the submodule due to being shallow. Use the new file t5614 to document
>> and test expectations in this area.
>>
>
> The description seems to imply that there will be
> "test_expect_failure" tests to indicate what needs to be improved...
> Maybe I am just mis-reading it?

That commit message certainly reads like that. I'll tone it down to just say it's testing the shallowness.

Lars wrote:

Show 7 quoted lines

>> +test_expect_success 'shallow clone implies shallow submodule' '
>> +     test_when_finished "rm -rf super_clone" &&
>> +     git clone --recurse-submodules --no-local --depth 1 . super_clone &&
>
> You could add another commit to the super repo and then clone with "--depth 2".
> The super repo would then contain 2 lines and the submodule still just 1.
> This would make it more obvious that shallow submodules always have a depth of 1.

ok will fix.