Re: [PATCH] diff: --color-moved: rename "dimmed_zebra" to "dimmed-zebra"

From: Stefan Beller <sbeller@google.com>
Date: Jul 24, 2018, 22:42 UTC
Message-ID: <CAGZ79kbL2mHK9TzH6guRjJkzmaVSbMiPr5M47RPMtYzp782iFQ@mail.gmail.com>
In-Reply-To: <20180724220928.GE136514@aiede.svl.corp.google.com>

On Tue, Jul 24, 2018 at 3:09 PM Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 9 quoted lines

> Hm.  Looks like dimmed_zebra was introduced in v2.15.0-rc0~16^2~2
> (2017-06-30), so it has been around for a while (about a year).  But I
> would like to be able to simplify by getting rid of it.
>
> https://codesearch.debian.net/search?q=dimmed_zebra doesn't find any
> instances of it being used outside Git itself.
>
> https://twitter.com/kornelski/status/982247477020508162 (found with a
> web search) shows that some people may have it in configuration.

Thanks for the searches.

Show 5 quoted lines

>
> I don't have any good ideas about deprecating more aggressively, and
> the patch looks good, so
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Same here. I wonder if we actually ever want to deprecate it further than this patch, as the additional code to support it is only 2 lines. So the effort to deprecate it (more than this patch) is more than keeping the misnamed version around forever.

Thanks! Stefan