Re: What's cooking in git.git (May 2018, #04; Wed, 30)
- From
Stefan Beller <sbeller@google.com>
- Date
- May 30, 2018, 16:43 UTC
- Message-ID
- <CAGZ79kbL-EJ9ithyxMgs0G_vcp7+Dno5tkEk2Vds8mmgUmaQVA@mail.gmail.com>
- In-Reply-To
- <CACsJy8DW8e4rFWzzc4WxLRtK-WTAcG_BwFSxAya_fLfXOk9p8A@mail.gmail.com>
On Wed, May 30, 2018 at 9:27 AM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 23 quoted lines
> On Wed, May 30, 2018 at 8:38 AM, Junio C Hamano <gitster@pobox.com> wrote: >> * sb/object-store-alloc (2018-05-16) 13 commits >> - alloc: allow arbitrary repositories for alloc functions >> - object: allow create_object to handle arbitrary repositories >> - object: allow grow_object_hash to handle arbitrary repositories >> - alloc: add repository argument to alloc_commit_index >> - alloc: add repository argument to alloc_report >> - alloc: add repository argument to alloc_object_node >> - alloc: add repository argument to alloc_tag_node >> - alloc: add repository argument to alloc_commit_node >> - alloc: add repository argument to alloc_tree_node >> - alloc: add repository argument to alloc_blob_node >> - object: add repository argument to grow_object_hash >> - object: add repository argument to create_object >> - repository: introduce parsed objects field >> (this branch is used by sb/object-store-grafts.) >> >> The conversion to pass "the_repository" and then "a_repository" >> throughout the object access API continues. >> >> Is this ready for 'next'? > > I think so.
I think so, too. (I even think that for sb/object-store-grafts.)
> Stefan could remove the comment "/* TODO: what about > commit->util? */" if he wants since nd/commit-util-to-slab is already > in next. But this is really minor and does not need fixing to land on > 'next'.
I was about to remove that comment in the follow up[1] that I sent out yesterday, but refrained. Now that the removal of util is being merged to master, I'll include that in that series
[1] https://public-inbox.org/git/20180530004810.30076-1-sbeller@google.com/