git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] quote-email populates the fields

From
Stefan Beller <sbeller@google.com>
Date
Nov 1, 2017, 18:12 UTC
Message-ID
<CAGZ79kbCkj+=tUPL6W48cedSzETsydpHSMkZX=Xn7XnVijpjZQ@mail.gmail.com>
In-Reply-To
<q7h97evaxntq.fsf@orange.lip.ens-lyon.fr>
On Wed, Nov 1, 2017 at 4:04 AM, Matthieu Moy <Matthieu.Moy@univ-lyon1.fr> wrote:
Show 27 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Payre Nathan <second.payre@gmail.com> writes:
>>
>>> From: Tom Russello <tom.russello@grenoble-inp.org>
>>>
>>> ---
>>
>> Missing something here???
>
> To clarify for Nathan, Thimothee and Danial: the cover-letter is an
> introduction send before the patch series. It can be needed to explain
> the overall approach followed by the series. But in general, it does not
> end up in the Git history, i.e. after the review is finished, the
> cover-letter is forgotten.
>
> OTOH, the commit messages for each patch is what ends up in the Git
> history. This is what people will find later when running e.g. "git
> blame", "git bisect" or so. Clearly the future user examining history
> expects more than "quote-email populates the fields" (which was a good
> reminder during development, but is actually a terrible subject line for
> a final version).
>
> A quick advice: if in doubt, prefer writing explanations in commit
> message rather than the cover letter. If still in doubt, write the
> explanations twice: once quickly in the cover letter and once more
> detailed in the commit message.
Oh, and I thought the sign offs.
Previous: Matthieu MoyNext: Matthieu Moy
Message 8 of 9 in “New send-email option --quote-email”
  1. 0/2 New send-email option --quote-emailPayre Nathan, Oct 30, 2017
  2. 1/2 quote-email populates the fieldsPayre Nathan, Oct 30, 2017
  3. Junio C HamanoNov 1, 2017
  4. Nathan PAYRENov 9, 2017
  5. 2/2 send-email: quote-email quotes the message bodyPayre Nathan, Oct 30, 2017
  6. Junio C HamanoNov 1, 2017
  7. Matthieu MoyNov 1, 2017
  8. Stefan BellerNov 1, 2017
  9. Matthieu MoyNov 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.