git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/16] object_id part 14

From
Stefan Beller <sbeller@google.com>
Date
Jul 16, 2018, 18:04 UTC
Message-ID
<CAGZ79kbAMJXAPtc5b45_PRDC=AQRKUYLC8seXqfMrJZEaL-KfQ@mail.gmail.com>
In-Reply-To
<20180716152152.GA51419@syl.attlocal.net>
On Mon, Jul 16, 2018 at 8:21 AM Taylor Blau <me@ttaylorr.com> wrote:
Show 18 quoted lines
>
> On Mon, Jul 16, 2018 at 01:27:52AM +0000, brian m. carlson wrote:
> > This is the fourteenth series of patches to switch to using struct
> > object_id and the_hash_algo.  This series converts several core pieces
> > to use struct object_id, including the oid* and hex functions.
> >
> > All of these patches have been tested with both SHA-1 and a 256-bit
> > hash.
> >
> > Most of these patches are fixes for things that will clearly cause
> > segfaults or other very obvious breakage on a Git with a 256-bit hash.
> >
> > Changes from v1:
> > * Drop patch that's been replaced by one from Ben Peart.
> > * Update patch handling hash* and oid* functions.
>
> Along with Derrick, I also read this series and found it to be without
> problems. This looks good to me, too.

I just had a hickup with the patch replacing number magic ( "(num_parents * 50) + 20") in a strbuf_grow, but I do not see the problem there, it is just a bit of overly large grow estimates. Despite that said, this series is

Reviewed-by: Stefan Beller <sbeller@google.com>

Thanks, Stefan

Previous: Taylor Blau
Message 20 of 20 in “object_id part 14”
  1. 00/16 object_id part 14brian m. carlson, Jul 16, 2018
  2. 01/16 cache: update object ID functions for the_hash_algobrian m. carlson, Jul 16, 2018
  3. 02/16 tree-walk: replace hard-coded constants with the_hash_algobrian m. carlson, Jul 16, 2018
  4. 03/16 hex: switch to using the_hash_algobrian m. carlson, Jul 16, 2018
  5. 05/16 strbuf: allocate space with GIT_MAX_HEXSZbrian m. carlson, Jul 16, 2018
  6. 04/16 commit: express tree entry constants in terms of the_hash_algobrian m. carlson, Jul 16, 2018
  7. 07/16 refs/files-backend: use the_hash_algo for writing refsbrian m. carlson, Jul 16, 2018
  8. 08/16 builtin/update-index: convert to using the_hash_algobrian m. carlson, Jul 16, 2018
  9. 09/16 builtin/update-index: simplify parsing of cacheinfobrian m. carlson, Jul 16, 2018
  10. 06/16 sha1-name: use the_hash_algo when parsing object namesbrian m. carlson, Jul 16, 2018
  11. 10/16 builtin/fmt-merge-msg: make hash independentbrian m. carlson, Jul 16, 2018
  12. 11/16 builtin/merge: switch to use the_hash_algobrian m. carlson, Jul 16, 2018
  13. 12/16 builtin/merge-recursive: make hash independentbrian m. carlson, Jul 16, 2018
  14. 13/16 diff: switch GIT_SHA1_HEXSZ to use the_hash_algobrian m. carlson, Jul 16, 2018
  15. 14/16 log-tree: switch GIT_SHA1_HEXSZ to the_hash_algo->hexszbrian m. carlson, Jul 16, 2018
  16. 15/16 sha1-file: convert constants to uses of the_hash_algobrian m. carlson, Jul 16, 2018
  17. 16/16 pretty: switch hard-coded constants to the_hash_algobrian m. carlson, Jul 16, 2018
  18. Derrick StoleeJul 16, 2018
  19. Taylor BlauJul 16, 2018
  20. Stefan BellerJul 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.