Re: [RFC PATCH] NonStop port changes for git 2.16.0.

From: Stefan Beller <sbeller@google.com>
Date: Jan 18, 2018, 22:50 UTC
Message-ID: <CAGZ79kb4Zr6QnNydRX56B_4Jo5fveufBFJAD7r_8U-NRSMa2qQ@mail.gmail.com>
In-Reply-To: <20180118224243.5016-1-randall.s.becker@rogers.com>

On Thu, Jan 18, 2018 at 2:42 PM,  <randall.s.becker@rogers.com> wrote:

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> Explanation: I'm looking for comments on how best to handle the changes
> below that are needed for the NonStop port.

Ideally you'd send them as single patches, each of them describing why it makes sense generally (such as the s/read/xread/ line) or specifically for your arch (these #ifdefs and Makefile changes).

Show 11 quoted lines

> The hashmap.h and
> transport-helper.c will not be included in the final patch as they have
> already been communicated but did not make it into 2.16.0.
> It is likely that some of the changes below are in the wrong files
> (for example: NSIG, intptr_t) and should be moved. This is just the
> current state of the port, as it grew (and fortunately shrank a lot)
> over the past few years. My objective, as the platform maintainer, is
> to clean it up, and to try to get the platform's modifications
> included so that we can just (obviously) pull directly from the standard
> repository and not have to apply these mods in future and focus on
> any platform-related breakages.

Thanks for keeping up with the latest version! The xread issue sounds like you found a bug across all platforms, which is valued by the wider community. So feel free to send individual patches and the list will get back to you. :)

> Further: there are 6 known breakages that have been reported. The perl
> issues relating to completion codes are being examined at present by the
> platform support teams so are not addressed by this patch.

For perl I'd suggest cc'ing Ævar (cc'd just now) as that seems his field of expertise.

Thanks for such a report, Stefan