Re: [PATCH] lib-submodule-update.sh: drop unneeded shell
- From
Stefan Beller <sbeller@google.com>
- Date
- Jan 13, 2017, 20:01 UTC
- Message-ID
- <CAGZ79kayLoH7EURQ9aKGh+FzDz_BegJRjB2175qo53beLZDYog@mail.gmail.com>
- In-Reply-To
- <xmqqa8auhgzt.fsf@gitster.mtv.corp.google.com>
On Fri, Jan 13, 2017 at 11:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> Stefan Beller <sbeller@google.com> writes: >> >>> In modern Git we prefer "git -C <cmd" over "(cd <somewhere && git <cmd>)" >>> as it doesn't need an extra shell. >> >> There is a matching '>' missing. The description is correct (I am >> not sure if there actually is "preference", though), but I found the >> title a bit misleading.... > > It turns out that there were two missing '>' ;-) It tentatively has > become like this in my tree.
Thanks for fixing up locally. I had resent as "[PATCH] lib-submodule-update.sh: reduce use of subshell by using git -C <dir>" but you can ignore that now.
Thank, Stefan