Re: [PATCHv12 06/10] receive-pack.c: negotiate atomic push support
- From
Stefan Beller <sbeller@google.com>
- Date
- Jan 12, 2015, 23:43 UTC
- Message-ID
- <CAGZ79kaxFqtxBE+LaWbh92b8RK-qganuADjsnwHU5WO-oJebcw@mail.gmail.com>
- In-Reply-To
- <CAPig+cQv6Dr7z56qXiqzZLmuBt=_TWcPSpQSTyLv0euT-k+umA@mail.gmail.com>
On Mon, Jan 12, 2015 at 3:29 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 10 quoted lines
> Is this needed only to support the tests you add in t5543, or do you > intend it to be useful to end users? > > If it is for end users, then it deserves to be documented. Is also > deserves proper mention and justification in the commit message. > > If it's only intended to assist automated testing, then perhaps > control it via an environment variable rather than a configuration > option. (See, for instance, GIT_TEST_SPLIT_INDEX or GIT_USE_LOOKUP as > precedent.)
I added that after reading https://www.marc.info/?l=git&m=141995803919542&w=2 which makes me believe we actually want to expose this to the enduser.
Documentation will follow soon.