git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

From
Stefan Beller <sbeller@google.com>
Date
Feb 28, 2018, 18:59 UTC
Message-ID
<CAGZ79kaurxM+Daa43ZQ_LCn6HbiaXex_NtO73g2ip70RUpjM7A@mail.gmail.com>
In-Reply-To
<xmqqy3jdknar.fsf@gitster-ct.c.googlers.com>
On Wed, Feb 28, 2018 at 9:59 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> Looking at the full-series diff though, it makes me wonder if we
>> should keep prepare_packed_git() private (i.e. how we initialize the
>> object store, packfile included, is a private matter). How about
>> something like this on top?
>
> Yup, that looks cleaner.

I agree that it looks cleaner. So we plan on just putting it on top of that series?

Thanks for the help on refactoring, Stefan

Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 23 in “Moving global state into the repository object (part 2)”
  1. 00/11 Moving global state into the repository object (part 2)Stefan Beller, Feb 28, 2018
  2. 01/11 packfile: allow prepare_packed_git_mru to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  3. 02/11 packfile: allow rearrange_packed_git to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  4. 03/11 packfile: allow install_packed_git to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  5. Derrick StoleeFeb 28, 2018
  6. 05/11 packfile: add repository argument to prepare_packed_gitStefan Beller, Feb 28, 2018
  7. 07/11 packfile: allow prepare_packed_git_one to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  8. 08/11 packfile: allow prepare_packed_git to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  9. 06/11 packfile: add repository argument to reprepare_packed_gitStefan Beller, Feb 28, 2018
  10. 11/11 packfile: allow find_pack_entry to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  11. 04/11 packfile: add repository argument to prepare_packed_git_oneStefan Beller, Feb 28, 2018
  12. 09/11 packfile: allow reprepare_packed_git to handle arbitrary repositoriesStefan Beller, Feb 28, 2018
  13. 10/11 packfile: add repository argument to find_pack_entryStefan Beller, Feb 28, 2018
  14. Duy NguyenFeb 28, 2018
  15. Derrick StoleeFeb 28, 2018
  16. Junio C HamanoFeb 28, 2018
  17. Stefan BellerFeb 28, 2018
  18. Junio C HamanoFeb 28, 2018
  19. Junio C HamanoFeb 28, 2018
  20. Stefan BellerFeb 28, 2018
  21. Jonathan NiederFeb 28, 2018
  22. Junio C HamanoFeb 28, 2018
  23. Stefan BellerFeb 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.