git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/4] Hash abstraction

From
Stefan Beller <sbeller@google.com>
Date
Nov 22, 2017, 16:57 UTC
Message-ID
<CAGZ79kaufHTT2dcfgMP-hve-Sj9G85SajDdGivKg1Ho3pu0Vgg@mail.gmail.com>
In-Reply-To
<xmqqbmjuu4zt.fsf@gitster.mtv.corp.google.com>
On Tue, Nov 21, 2017 at 11:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>>> This is a series proposing a basic abstraction for hash functions.
>>>
>>> The full description of the series can be found here:
>>> https://public-inbox.org/git/20171028181239.59458-1-sandals@crustytoothpaste.net/
>>>
>>> At the bottom of this message is the output of git tbdiff between v2 and
>>> v3.
>>>
>>> Changes from v2:
>>> * Remove inline.
>>> * Add dummy functions that call die for unknown hash implementation.
>>> * Move structure definitions to hash.h and include git-compat-util.h in
>>>   hash.h.
>>> * Rename current_hash to the_hash_algo.
>>> * Use repo_set_hash_algo everywhere we set the hash algorithm for a
>>>   struct repository.
>>
>> Change for all of the above in this series looked sensible to me.
>> Thank, will queue.
>
> So... is everybody happy enough with this version that nobody minds
> more codebase to be adjusted on the infrastructure this series lays
> out?  I think this is ready for 'next', but just in case I missed
> some discussions...
yeah I was happy at the time of review; sorry for not saying so.
Previous: Junio C Hamano
Message 9 of 9 in “Hash abstraction”
  1. 0/4 Hash abstractionbrian m. carlson, Nov 12, 2017
  2. 1/4 setup: expose enumerated repo infobrian m. carlson, Nov 12, 2017
  3. 2/4 Add structure representing hash algorithmbrian m. carlson, Nov 12, 2017
  4. 4/4 Switch empty tree and blob lookups to use hash abstractionbrian m. carlson, Nov 12, 2017
  5. Stefan BellerNov 13, 2017
  6. 3/4 Integrate hash algorithm support with repo setupbrian m. carlson, Nov 12, 2017
  7. Junio C HamanoNov 13, 2017
  8. Junio C HamanoNov 22, 2017
  9. Stefan BellerNov 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.