Re: [PATCH 0/6] Rename files to use dashes instead of underscores
- From
Stefan Beller <sbeller@google.com>
- Date
- Apr 10, 2018, 22:47 UTC
- Message-ID
- <CAGZ79kakGDwK_NgF0Y77mjj0mskgqed6ffu0UYdSnVquC-ef9w@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1804110038230.56@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
Hi Johannes,
On Tue, Apr 10, 2018 at 3:39 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 22 quoted lines
> Hi Stefan, > > On Tue, 10 Apr 2018, Stefan Beller wrote: > >> This is the followup for >> https://public-inbox.org/git/xmqqbmer4vfh.fsf@gitster-ct.c.googlers.com/ >> >> We have no files left with underscores in their names. > > Yaaay! > >> Stefan Beller (6): >> write_or_die.c: rename to use dashes in file name >> unicode_width.h: rename to use dash in file name >> exec_cmd: rename to use dash in file name >> sha1_name.c: rename to use dash in file name >> sha1_file.c: rename to use dash in file name >> replace_object.c: rename to use dash in file name > > These are all obviously correct (I did not apply the series and used `git > grep` to verify that nothing underscored is left there, but I trust you to > have done that already).
Yes and I did not tell the full story.
There is still 'check_bindir' as compile output, such that I ignored it.
And there was sha1dc_git.{h, c} which I also ignored as it is unclear to me how our relationship with the DC library is. I think that could also be converted as it seems to be a shallow wrapper around that lib.