Re: [PATCH 1/5] t4015: refactor --color-moved whitespace test
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 19, 2017, 20:56 UTC
- Message-ID
- <CAGZ79kahYb5=BEvr0io-bSJ+JaOfViicyghH4CtRErqmtAXU-g@mail.gmail.com>
- In-Reply-To
- <20171019202403.7srcpos5xlsvmqrl@sigill.intra.peff.net>
On Thu, Oct 19, 2017 at 1:24 PM, Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> > +test_expect_success 'clean up whitespace-test colors' ' > + git config --unset color.diff.oldMoved && > + git config --unset color.diff.newMoved > +'
This could be part of the previous test as
test_config color.diff.oldMoved "magenta" && test_config color.diff.newMoved "cyan" &&
in the beginning. (That way we also do not pollute the setup, but keeping it test local).
With or without this nit, this is Reviewed-by: Stefan Beller <sbeller@google.com>
Thanks, Stefan