Re: [PATCH] Documentation/SubmittingPatches: add quotes to advised commit reference
- From
Stefan Beller <sbeller@google.com>
- Date
- Aug 26, 2016, 22:45 UTC
- Message-ID
- <CAGZ79kag07E_n+4KjOqqv-mxLe0T1VYjnuu5mT1k_EXLBcaYvQ@mail.gmail.com>
- In-Reply-To
- <xmqqk2f3duf2.fsf@gitster.mtv.corp.google.com>
On Fri, Aug 26, 2016 at 3:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Perhaps something like this instead? > > -- >8 --
This is way better. Let's take that.
Thanks, Stefan
Show 37 quoted lines
> From: Beat Bolli <dev+git@drbeat.li>
> Subject: SubmittingPatches: use gitk's "Copy commit summary" format
> Date: Fri, 26 Aug 2016 18:59:01 +0200
>
> Update the suggestion in 175d38ca ("SubmittingPatches: document how
> to reference previous commits", 2016-07-28) on the format to refer
> to a commit to match what gitk has been giving since last year with
> its "Copy commit summary" command; also mention this as one of the
> ways to obtain a commit reference in this format.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---
> Documentation/SubmittingPatches | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 500230c..15adb86 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -122,9 +122,14 @@ without external resources. Instead of giving a URL to a mailing list
> archive, summarize the relevant points of the discussion.
>
> If you want to reference a previous commit in the history of a stable
> -branch use the format "abbreviated sha1 (subject, date)". So for example
> -like this: "Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30)
> -noticed [...]".
> +branch, use the format "abbreviated sha1 (subject, date)",
> +with the subject enclosed in a pair of double-quotes, like this:
> +
> + Commit f86a374 ("pack-bitmap.c: fix a memleak", 2015-03-30)
> + noticed that ...
> +
> +The "Copy commit summary" command of gitk can be used to obtain this
> +format.
>
>
> (3) Generate your patch using Git tools out of your commits.