Re: [RFC/PATCH v3 5/5] WIP clone: add a --[no-]recommend-tags & submodule.NAME.tags config

From: Stefan Beller <sbeller@google.com>
Date: Apr 27, 2017, 19:36 UTC
Message-ID: <CAGZ79kadPPBxW01p8KFGrcj3XwT1VZCcNTG4O_vxpU5n-ZRPFA@mail.gmail.com>
In-Reply-To: <20170426231236.27219-6-avarab@gmail.com>

On Wed, Apr 26, 2017 at 4:12 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 7 quoted lines

> @@ -855,7 +856,7 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce,
>                 argv_array_pushl(&child->args, "--prefix", suc->prefix, NULL);
>         if (suc->recommend_shallow && sub->recommend_shallow == 1)
>                 argv_array_push(&child->args, "--depth=1");
> -       if (suc->no_tags)
> +       if (suc->no_tags || suc->recommend_tags == 0)
>                 argv_array_push(&child->args, "--no-tags");

Here you would also need to pay attention to sub->recommend_tags?