Re: What's cooking in git.git (Apr 2016, #03; Thu, 7)

From: Stefan Beller <sbeller@google.com>
Date: Apr 12, 2016, 16:25 UTC
Message-ID: <CAGZ79kad=9-TA7yFhkOesMv63DWN_wPNYEj249ne6Le1QRsN1Q@mail.gmail.com>
In-Reply-To: <xmqqfuuxz1jh.fsf@gitster.mtv.corp.google.com>

On Thu, Apr 7, 2016 at 12:01 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> * sb/submodule-helper-clone-regression-fix (2016-04-01) 6 commits
>  - submodule--helper, module_clone: catch fprintf failure
>  - submodule--helper: do not borrow absolute_path() result for too long
>  - submodule--helper, module_clone: always operate on absolute paths
>  - submodule--helper clone: create the submodule path just once
>  - submodule--helper: fix potential NULL-dereference
>  - recursive submodules: test for relative paths
>
>  A partial rewrite of "git submodule" in the 2.7 timeframe changed
>  the way the gitdir: pointer in the submodules point at the real
>  repository location to use absolute paths by accident.  This has
>  been corrected.
>
>  Any further comments?  Otherwise will merge to 'next'.

I've looked through that code again now and responded to Ramsay Jones, who found an issue with another version of the patches (0 instead of NULL passed into strbuf_detach), but the current version of sb/submodule-helper-clone-regression-fix doesn't have that issue.

Please merge to 'next'.