Re: [PATCH] document submodule sync --recursive

From: Stefan Beller <sbeller@google.com>
Date: Dec 3, 2015, 20:22 UTC
Message-ID: <CAGZ79kaX4ZM++jhPcpU0T8eYDobME=iNtbH3KceWbQOOavpHnA@mail.gmail.com>
In-Reply-To: <xmqqh9jzthh3.fsf@gitster.mtv.corp.google.com>

On Thu, Dec 3, 2015 at 12:17 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

>>
>> Tested-by: Per Cederqvist <cederp@opera.com>
>
> Isn't this Reported-by? (genuine question; I haven't caught up with
> my inbox backlog and do not claim having seen everything Per wrote
> to this list).

Per wrote he tested `git submodule sync --recursive` with 2.6.3, so yeah the tested refers to the underlying command, not this patch. So Reported-by is better here.

Show 8 quoted lines

>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>
>>  This applies on origin/master.
>
> Thanks.  Should it go to maintenance track (iow, was the feature
> that wasn't documented already in maint)?

It was introduced via (82f49f294c, Teach --recursive to submodule sync, 2012-10-26) so I guess maint is fine, too

Show 7 quoted lines

>> @@ -237,6 +237,9 @@ sync::
>>  +
>>  "git submodule sync" synchronizes all submodules while
>>  "git submodule sync \-- A" synchronizes submodule "A" only.
>> ++
>> +If `--recursive` is specified, this command will recurse into the
>> +registered submodules, and update any nested submodules within.

I should have paid more attention here and s/update/sync/.

I'll prepare a resend.