git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/13] remove_branches(): remove temporary

From
Stefan Beller <sbeller@google.com>
Date
Jun 8, 2015, 16:45 UTC
Message-ID
<CAGZ79kaW-jT5x2SNLjL6xtY=Qe_U86G6+nh8y2sP9Sv=CHc5Kg@mail.gmail.com>
In-Reply-To
<77713838b598b95c5973a1fe73569635f5f31ee9.1433763494.git.mhagger@alum.mit.edu>
On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Found-to-be-Obviously-Correct-by: Stefan Beller <sbeller@google.com> ;)
Show 21 quoted lines
> ---
>  builtin/remote.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/builtin/remote.c b/builtin/remote.c
> index f4a6ec9..53b8e13 100644
> --- a/builtin/remote.c
> +++ b/builtin/remote.c
> @@ -756,8 +756,7 @@ static int remove_branches(struct string_list *branches)
>         strbuf_release(&err);
>
>         for (i = 0; i < branches->nr; i++) {
> -               struct string_list_item *item = branches->items + i;
> -               const char *refname = item->string;
> +               const char *refname = branches->items[i].string;
>
>                 if (delete_ref(refname, NULL, 0))
>                         result |= error(_("Could not remove branch %s"), refname);
> --
> 2.1.4
>
Previous: Michael HaggertyNext: Michael Haggerty
Message 8 of 30 in “Improve "refs" module encapsulation”
  1. 00/13 Improve "refs" module encapsulationMichael Haggerty, Jun 8, 2015
  2. 01/13 delete_ref(): move declaration to refs.hMichael Haggerty, Jun 8, 2015
  3. Stefan BellerJun 8, 2015
  4. Michael HaggertyJun 9, 2015
  5. Stefan BellerJun 9, 2015
  6. Michael HaggertyJun 13, 2015
  7. 02/13 remove_branches(): remove temporaryMichael Haggerty, Jun 8, 2015
  8. Stefan BellerJun 8, 2015
  9. 03/13 delete_ref(): handle special case more explicitlyMichael Haggerty, Jun 8, 2015
  10. Stefan BellerJun 8, 2015
  11. Michael HaggertyJun 9, 2015
  12. 04/13 delete_refs(): new function for the refs APIMichael Haggerty, Jun 8, 2015
  13. 05/13 delete_refs(): improve error messageMichael Haggerty, Jun 8, 2015
  14. Junio C HamanoJun 9, 2015
  15. 06/13 delete_refs(): convert error message to lower caseMichael Haggerty, Jun 8, 2015
  16. Stefan BellerJun 8, 2015
  17. Michael HaggertyJun 9, 2015
  18. 07/13 prune_remote(): use delete_refs()Michael Haggerty, Jun 8, 2015
  19. Stefan BellerJun 8, 2015
  20. Jeff KingJun 8, 2015
  21. Michael HaggertyJun 9, 2015
  22. Jeff KingJun 9, 2015
  23. 08/13 repack_without_refs(): make function privateMichael Haggerty, Jun 8, 2015
  24. 09/13 initial_ref_transaction_commit(): function for initial ref creationMichael Haggerty, Jun 8, 2015
  25. 10/13 refs: remove some functions from the module's public interfaceMichael Haggerty, Jun 8, 2015
  26. 11/13 initial_ref_transaction_commit(): check for duplicate refsMichael Haggerty, Jun 8, 2015
  27. 12/13 initial_ref_transaction_commit(): check for ref D/F conflictsMichael Haggerty, Jun 8, 2015
  28. 13/13 refs: move the remaining ref module declarations to refs.hMichael Haggerty, Jun 8, 2015
  29. Stefan BellerJun 8, 2015
  30. Junio C HamanoJun 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.