git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/6] refs.c: replace write_str_in_full by write_in_full

From
Stefan Beller <sbeller@google.com>
Date
Jan 21, 2015, 23:44 UTC
Message-ID
<CAGZ79kaTUraVYc1Th0-8ajw4kMuU-Sir2e9dW1uy90CuQRzgeg@mail.gmail.com>
In-Reply-To
<20150121233843.GB11115@peff.net>
On Wed, Jan 21, 2015 at 3:38 PM, Jeff King <peff@peff.net> wrote:
Show 10 quoted lines
> On Wed, Jan 21, 2015 at 03:23:42PM -0800, Stefan Beller wrote:
>
>> There is another occurrence where we could have used write_str_in_full
>> (line 3107: write_in_full(lock->lk->fd, &term, 1)), so the current state
>> is inconsistent. This replaces the only occurrence of write_str_in_full
>> by write_in_full, so we only need to wrap write_in_full in the next patch.
>
> I had to read the first sentence a few times to figure out what you
> meant. But I am not sure it is even relevant. We do not care about the
> inconsistency.

You're not the first who needs to reread my stuff :/ I have the impression my English worsened since coming into the USA.

We do not care about the inconsistency, but we may care about the change itself: "write_str_in_full is way better than write_in_full, so why the step backwards?" And I am trying to explain that this is not a huge step backwards but rather improves consistency.

> It is just "we are about to change how callers of
> write_in_full in this file behave, the wrapper gets in the way, and it
> does not add enough value by itself to merit making our future changes
> in two places".

That's actually true. Though that sounds as if we'd be lazy ("we only want to make one change, so let's bend over here")

I'll rethink the commit message. Thanks, Stefan

Previous: Jeff KingNext: Jeff King
Message 7 of 18 in “[PATCHv1 0/6] Fix bug in large transactions”
  1. Stefan BellerJan 21, 2015
  2. 1/6 update-ref: Test handling large transactions properlyStefan Beller, Jan 21, 2015
  3. Jeff KingJan 21, 2015
  4. 2/6 refs.c: remove lock_fd from struct ref_lockStefan Beller, Jan 21, 2015
  5. 3/6 refs.c: replace write_str_in_full by write_in_fullStefan Beller, Jan 21, 2015
  6. Jeff KingJan 21, 2015
  7. Stefan BellerJan 21, 2015
  8. Jeff KingJan 21, 2015
  9. 4/6 refs.c: Have a write_in_full_to_lock_file wrapping write_in_fullStefan Beller, Jan 21, 2015
  10. Jeff KingJan 21, 2015
  11. 5/6 refs.c: write to a lock file only onceStefan Beller, Jan 21, 2015
  12. Jeff KingJan 21, 2015
  13. 6/6 refs.c: enable large transactionsStefan Beller, Jan 21, 2015
  14. Jeff KingJan 21, 2015
  15. Junio C HamanoJan 22, 2015
  16. Stefan BellerJan 22, 2015
  17. Junio C HamanoJan 22, 2015
  18. Stefan BellerJan 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.