git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule: Alllow staged changes for get_superproject_working_tree

From
Stefan Beller <sbeller@google.com>
Date
Sep 27, 2018, 19:42 UTC
Message-ID
<CAGZ79kaRYra+2Ue2TSS74tE_gdg8ppSfNtVQK4LhOrQTj8td8Q@mail.gmail.com>
In-Reply-To
<20180927181054.25802-1-sammck@gmail.com>
On Thu, Sep 27, 2018 at 11:12 AM Sam McKelvie <sammck@gmail.com> wrote:
Show 25 quoted lines
>
> Invoking 'git rev-parse --show-superproject-working-tree' exits with
>
>     "fatal: BUG: returned path string doesn't match cwd?"
>
> when the superproject has an unmerged entry for the current submodule,
> instead of displaying the superproject's working tree.
>
> The problem is due to the fact that when a merge of the submodule reference
> is in progress, "git ls-files --stage —full-name <submodule-relative-path>”
> returns three seperate entries for the submodule (one for each stage) rather
> than a single entry; e.g.,
>
> $ git ls-files --stage --full-name submodule-child-test
> 160000 dbbd2766fa330fa741ea59bb38689fcc2d283ac5 1       submodule-child-test
> 160000 f174d1dbfe863a59692c3bdae730a36f2a788c51 2       submodule-child-test
> 160000 e6178f3a58b958543952e12824aa2106d560f21d 3       submodule-child-test
>
> The code in get_superproject_working_tree() expected exactly one entry to
> be returned; this patch makes it use the first entry if multiple entries
> are returned.
>
> Test t1500-rev-parse is extended to cover this case.
>
> Signed-off-by: Sam McKelvie <sammck@gmail.com>
Thanks for following up, this patch is
Reviewed-by: Stefan Beller <sbeller@google.com>

Thanks for adding the test as well! Stefan

Previous: Sam McKelvieNext: Junio C Hamano
Message 2 of 9 in “submodule: Alllow staged changes for get_superproject_working_tree”
  1. submodule: Alllow staged changes for get_superproject_working_treeSam McKelvie, Sep 27, 2018
  2. Stefan BellerSep 27, 2018
  3. Junio C HamanoSep 27, 2018
  4. Sam McKelvieSep 28, 2018
  5. Junio C HamanoSep 28, 2018
  6. Sam McKelvieSep 28, 2018
  7. Junio C HamanoSep 28, 2018
  8. Sam McKelvieSep 28, 2018
  9. Junio C HamanoSep 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.