Re: [PATCH 3/6] Add tests for git status `--ignored=matching`

From: Stefan Beller <sbeller@google.com>
Date: Oct 5, 2017, 21:59 UTC
Message-ID: <CAGZ79kaP7EthkcbAtuCSiFTU=nG8g-smxk5ZP=K=G5Ez2ZcsSQ@mail.gmail.com>
In-Reply-To: <20171005205443.206900-4-jameson.miller81@gmail.com>

On Thu, Oct 5, 2017 at 1:54 PM,  <jameson.miller81@gmail.com> wrote:

Show 25 quoted lines

> From: Jameson Miller <jamill@microsoft.com>
>
> Add tests for new ignored mode (matching) when showing all untracked
> files.
>
> Signed-off-by: Jameson Miller <jamill@microsoft.com>
> ---
>  t/t7519-ignored-mode.sh | 132 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 132 insertions(+)
>  create mode 100755 t/t7519-ignored-mode.sh
>
> diff --git a/t/t7519-ignored-mode.sh b/t/t7519-ignored-mode.sh
> new file mode 100755
> index 0000000000..a8c35d1cbc
> --- /dev/null
> +++ b/t/t7519-ignored-mode.sh
> @@ -0,0 +1,132 @@
> +#!/bin/sh
> +
> +test_description='git status collapse ignored'
> +
> +. ./test-lib.sh
> +
> +# commit initial ignore file
> +test_expect_success 'setup initial commit and ignore file' '

Here and in the following tests, I have the impression that the leading comment says the same as the test title, so you could omit the comments, putting all effort into a well word smithed test title.

Show 7 quoted lines

> +       cat >.gitignore <<-\EOF &&
> +       *.ign
> +       ignored_dir/
> +       !*.unignore
> +       EOF
> +       git add . &&
> +       test_tick &&

How is timing relevant to these test?

Thanks, Stefan