Re: [PATCH 2/2] t: move "git add submodule" into test blocks

From

Stefan Beller <sbeller@google.com>

Date

Jun 13, 2017, 17:15 UTC

Message-ID

<CAGZ79kaHXwEBJN-D6u+Zj4-Df-tMKBHz3S2uuOuH9mH5b6jd_A@mail.gmail.com>

In-Reply-To

<20170613092419.hzrtbn2jvykoxsry@sigill.intra.peff.net>

On Tue, Jun 13, 2017 at 2:24 AM, Jeff King <peff@peff.net> wrote:

> Some submodule tests do some setup outside of a test_expect
> block. This is bad because we won't actually check the
> outcome of those commands. But it's doubly so because "git
> add submodule" now produces a warning to stderr, which is
> not suppressed by the test scripts in non-verbose mode.

Makes sense.

> This patch does the minimal to fix the annoying warnings.
> All three of these scripts could use more cleanup of related
> setup.

agreed.

>
> Signed-off-by: Jeff King <peff@peff.net>

Reviewed-by: Stefan Beller <sbeller@google.com>