Re: [PATCHv17 01/11] submodule-config: keep update strategy around

From: Stefan Beller <sbeller@google.com>
Date: Feb 25, 2016, 18:21 UTC
Message-ID: <CAGZ79kaG+npqYDxABdUGrXH04nBF0_S+VLOHGrsa0jPcWMtiUQ@mail.gmail.com>
In-Reply-To: <xmqqwppsoeab.fsf@gitster.mtv.corp.google.com>

On Thu, Feb 25, 2016 at 10:06 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> +int parse_submodule_update_strategy(const char *value,
>> +             struct submodule_update_strategy *dst)
>> +{
>> +     free((void*)dst->command);
>
>         free((void *)dst->command);
>
> "git tbdiff" is quite handy; it didn't spot any other lossage of
> local tweak that was in 'pu', which is good.
>
> Thanks, will replace.

I usually use git diff <localbranch>.. origin/sb/feature to generate the interdiffs, so if you tweak things and I take these tweaks, then the interdiff is not complete.

On the other hand if I miss the tweak, such a diff shows a revert of the tweak.

I remember applying this tweak; not sure how it got lost again.