Re: Git compile warnings (under mac/clang)

From: Stefan Beller <sbeller@google.com>
Date: Jan 22, 2015, 19:59 UTC
Message-ID: <CAGZ79kaFWL5HWdctLzTWf6D4nTP19sPZbcOg9fiRx7RQrWjY7Q@mail.gmail.com>
In-Reply-To: <CAO2U3Qi6Xf1RrbxyVW3cHNe1-ZwxFHDVskGLZguWS=b38pgaXQ@mail.gmail.com>

cc Johannes Schindelin <Johannes.Schindelin@gmx.de> who is working in the fsck at the moment cc Peter Wu <peter@lekensteyn.nl> who worked on builtin/remote.c a few weeks ago

I just compiled origin/pu to test and also found a problem (doesn't happen in origin/master):

http.c: In function 'get_preferred_languages':
http.c:1020:2: warning: implicit declaration of function 'setlocale'
[-Wimplicit-function-declaration]
  retval = setlocale(LC_MESSAGES, NULL);
  ^
http.c:1020:21: error: 'LC_MESSAGES' undeclared (first use in this function)
  retval = setlocale(LC_MESSAGES, NULL);
                     ^
http.c:1020:21: note: each undeclared identifier is reported only once
for each function it appears in

so I cc Yi EungJun <eungjun.yi@navercorp.com> as well.

On Thu, Jan 22, 2015 at 11:43 AM, Michael Blume <blume.mike@gmail.com> wrote:

Show 30 quoted lines

> These are probably minor, I only bring them up because Git's build is
> generally so quiet that it might be worth squashing these too.
>
>     CC fsck.o
> fsck.c:110:38: warning: comparison of unsigned enum expression >= 0 is
> always true [-Wtautological-compare]
>         if (options->msg_severity && msg_id >= 0 && msg_id < FSCK_MSG_MAX)
>                                      ~~~~~~ ^  ~
> 1 warning generated.
>     AR libgit.a
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib:
> file: libgit.a(gettext.o) has no symbols
>     CC builtin/remote.o
> builtin/remote.c:1572:5: warning: add explicit braces to avoid
> dangling else [-Wdangling-else]
>                                 else
>                                 ^
> builtin/remote.c:1580:5: warning: add explicit braces to avoid
> dangling else [-Wdangling-else]
>                                 else
>                                 ^
> 2 warnings generated.
>
> (the warning about libgit.a(gettext.o) is probably because I'm
> building with NO_GETTEXT -- I've never been able to get gettext to
> work on my mac)
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html