Re: [PATCH] attr: mark a file-local symbol as static

From: Stefan Beller <sbeller@google.com>
Date: Nov 14, 2016, 20:00 UTC
Message-ID: <CAGZ79kaDK3syiNKvAKQf8q6AtcoXZuFz8fvxGZTj2Ced+Hu3Pg@mail.gmail.com>
In-Reply-To: <83508d1f-e809-f6be-5afc-4c23195dbd08@ramsayjones.plus.com>

On Sun, Nov 13, 2016 at 8:42 AM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 8 quoted lines

>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/attr' branch, could you please
> squash this into the relevant patch.

will do. I have it applied locally

>
> Alternatively, since there is only a single call site for git_attr()
> (on line #1005), you could perhaps remove git_attr() and inline that
> call. (However, that does make that line exceed 80 columns).

I'll look into that.

Thanks, Stefan

Show 24 quoted lines

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>  attr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/attr.c b/attr.c
> index 667ba85..84c4b08 100644
> --- a/attr.c
> +++ b/attr.c
> @@ -169,7 +169,7 @@ static struct git_attr *git_attr_internal(const char *name, int len)
>         return a;
>  }
>
> -struct git_attr *git_attr(const char *name)
> +static struct git_attr *git_attr(const char *name)
>  {
>         return git_attr_internal(name, strlen(name));
>  }
> --
> 2.10.0