Re: [PATCH 5/7] receive-pack: move execute_commands_non_atomic before execute_commands

From: Stefan Beller <sbeller@google.com>
Date: Dec 24, 2014, 00:30 UTC
Message-ID: <CAGZ79ka0hAko54g4rG27Ef=YFAXd-x50bPr0NSHRwPtDEobzHQ@mail.gmail.com>
In-Reply-To: <xmqqfvc7a6o3.fsf@gitster.dls.corp.google.com>

I tried all four diff options as listed in the man page of format-diff. I forget which one I used, but there was no large difference w.r.t. reviewability if I remember correctly.

On Mon, Dec 22, 2014 at 10:19 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> Notes:
>>     This patch is new with v6 of the series
>>
>>     As execute_commands_non_atomic is larger than execute_commands, the diff
>>     is not moving around execute_commands_non_atomic, but execute_commands.
>
> ;-)
>
> Next time perhaps try "--patience" to decide between with and
> without which one reads better?