git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Feature Request: option for git difftool to show changes in submodule contents

From
Stefan Beller <sbeller@google.com>
Date
Apr 23, 2018, 19:39 UTC
Message-ID
<CAGZ79ka-2OEYCqrZWEbWsR_QnZP_xr-yxg6jkWN4HYdKA+RJwQ@mail.gmail.com>
In-Reply-To
<HK2PR0601MB184272A36E86014BDD988DB5F9890@HK2PR0601MB1842.apcprd06.prod.outlook.com>
Hi Oshaben!

On Mon, Apr 23, 2018 at 7:49 AM, Oshaben Nicholas <nicholas.oshaben@bwigroup.com> wrote:

> Hello,
>
> A coworker of mine was trying to use git difftool in a repository with submodules and we found that it only shows the change in the subproject commit hash. The option to show the changes in the contents of the submodules exists for git diff. Can this be added to difftool as well?
Yes, of course it can be added. Care to write a patch?

See lines 432-443 in builtin/difftool.c: https://github.com/git/git/blob/master/builtin/difftool.c#L432

I'd think you'd want to compute some output (Similar to the git-diff output? Then we could just refactor the submodule diff stuff to be reusable here) and put it into the strbuf there.

Feel free to ask away or read the docs Documentation/SubmittingPatches

Thanks, Stefan

Previous: Oshaben Nicholas
Message 2 of 2 in “Feature Request: option for git difftool to show changes in submodule contents”
  1. Oshaben NicholasApr 23, 2018
  2. Stefan BellerApr 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.