Re: [PATCH] submodule--helper: set alternateLocation for cloned submodules
- From
Stefan Beller <sbeller@google.com>
- Date
- Dec 7, 2016, 20:26 UTC
- Message-ID
- <CAGZ79ka=XgO-VyS+Jqq2Fy28kPMy6HnXBAHb79Dt3NegZFd6kw@mail.gmail.com>
- In-Reply-To
- <xmqq4m2fxzl2.fsf@gitster.mtv.corp.google.com>
On Wed, Dec 7, 2016 at 12:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Stefan Beller <sbeller@google.com> writes: > >>> This patch makes all not just the root repository, but also >>> all submodules (recursively) have submodule.alternateLocation >>> and submodule.alternateErrorStrategy configured, making Git >>> search for possible alternates for nested submodules as well. >> >> Sounds great! > > Is it safe to assume that all the submodules used recursively by > submodules share the same structure upstream? Does the alternate > location mechanism degrades sensibly if this assumption turns out to > be false (i.e. "possible alternates" above turns out to be mere > possibility and not there)?
According to the last test in the patch, this seems to be doing the sensible thing.