Re: [PATCH 2/2] refs.c: upgrade for_each_replace_ref to be a each_repo_ref_fn callback

From: Stefan Beller <sbeller@google.com>
Date: Jul 18, 2018, 17:07 UTC
Message-ID: <CAGZ79kZyWWivaVgdCt-Zf-_3p9L5fis7ZC73pwDEGNQUfc8f+Q@mail.gmail.com>
In-Reply-To: <6c74aee8-2e18-99de-f775-dced1310809f@gmail.com>

Hi Derrick,

> Overall, I think this is the right approach. The only problem is that
> you're missing a few 'the_repository' to 'r' replacements in the bodies
> of show_reference and register_replace_ref.

Thanks.

Originally I had another approach, which was to convert all callbacks to take a repository argument, and only if the refs backend learned to propagate the correct repository the repo argument would be the specific repo, NULL otherwise.

With that approach it was not possible to replace all occurrences of the_repository with 'r', and it would also be confusing.

But as I pursued that approach at the time of writing this patch... I missed the conversions needed.

Thanks for catching them (and fixing them in the reroll that you just sent out via gitgitgadget)!

Thanks, Stefan