Re: [PATCH v3 3/4] batch check whether submodule needs pushing into one call
- From
Stefan Beller <sbeller@google.com>
- Date
- Nov 15, 2016, 22:28 UTC
- Message-ID
- <CAGZ79kZtQG5pE-6N-1yZKA95VRmrDRB3PnSd1gtqBM9fxD48Cg@mail.gmail.com>
- In-Reply-To
- <0f1aaa07e151f6be87eb61b434f8c9448f8dad75.1479221071.git.hvoigt@hvoigt.net>
On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
Show 5 quoted lines
> -static int submodule_needs_pushing(const char *path, const unsigned char sha1[20])
> +static int check_has_commit(const unsigned char sha1[20], void *data)
> {
> - if (add_submodule_odb(path) || !lookup_commit_reference(sha1))
> + int *has_commit = (int *) data;nit: just as prior patches ;) void* can be cast implicitly.