git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

From
Stefan Beller <sbeller@google.com>
Date
Dec 16, 2015, 22:46 UTC
Message-ID
<CAGZ79kZpCPp6CrfknQRDObKvuNnCe2+bZwCAF8XKrkkVNS+e3w@mail.gmail.com>
In-Reply-To
<xmqqio3yc8yd.fsf@gitster.mtv.corp.google.com>
On Wed, Dec 16, 2015 at 2:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> On Thu, Dec 3, 2015 at 5:10 AM, Mike Crowe <mac@mcrowe.com> wrote:
>>> t5531 only checked that the push.recurseSubmodules config option was
>>> overridden by passing --recurse-submodules=check on the command line.
>>> Add new tests for overriding with --recurse-submodules=no,
>>> --no-recurse-submodules and --recurse-submodules=push too.
>>>
>>> Also correct minor typo in test commit message.
>>>
>>> Signed-off-by: Mike Crowe <mac@mcrowe.com>
>>
>> This looks good to me.
>>
>> Thanks,
>> Stefan
>
> Thanks.  Does "This" refer to 1/2 alone or the whole series?
Yes. :)

"This" is applicable to both patches. We had the discussion on 2/2 about me misreading a line a few days earlier, but apart from that it looked good, too.

Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 16 in “push: add recurseSubmodules config option”
  1. push: add recurseSubmodules config optionMike Crowe, Dec 1, 2015
  2. Jeff KingDec 2, 2015
  3. Mike CroweDec 2, 2015
  4. push: Improve --recurse-submodules supportMike Crowe, Dec 2, 2015
  5. Junio C HamanoDec 2, 2015
  6. Mike CroweDec 3, 2015
  7. 1/2 push: Fully test --recurse-submodules on command line overrides configMike Crowe, Dec 3, 2015
  8. 2/2 push: Use "last one wins" convention for --recurse-submodulesMike Crowe, Dec 3, 2015
  9. Junio C HamanoDec 4, 2015
  10. Stefan BellerDec 10, 2015
  11. Junio C HamanoDec 10, 2015
  12. Stefan BellerDec 10, 2015
  13. Stefan BellerDec 16, 2015
  14. Junio C HamanoDec 16, 2015
  15. Stefan BellerDec 16, 2015
  16. Junio C HamanoDec 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.