Re: url.<base>.insteadOf vs. submodules
- From
Stefan Beller <sbeller@google.com>
- Date
- Feb 21, 2017, 18:19 UTC
- Message-ID
- <CAGZ79kZgMbEZy7hoA+VxsKdKBavt59SmC1c6FpDdgrW2GKMHvQ@mail.gmail.com>
- In-Reply-To
- <20170221070653.65ho2anbp55uzjeu@sigill.intra.peff.net>
On Mon, Feb 20, 2017 at 11:06 PM, Jeff King <peff@peff.net> wrote:
> > We'll see if the submodule folks have any ideas on how to implement > that. >
So from reading your discussion, the user expectation is to have `git submodule {init, update --init, sync}` to pay attention to url.<base>.insteadOf when setting up the submodule.<name>.URL, such that the modified URL is used for the initial clone of the submodule (and hence any subsequent usage within the submodule).
That sounds like a good idea to me.
Two caveates:
* After running `git submodule init`, you change url.<base>.insteadOf in the superproject. How do we need to word the documentation to have users expecting this change doesn't affect submodules? (See above Any vs. "Any except (initialized) submodules")
* So with the point above the insteadOf config only applies to the init/sync process, (i.e. once in time, ideally). Is that confusing or actually simplifying the submodule workflow?
Thanks, Stefan