git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] update-ref: Handle large transactions properly

From
Stefan Beller <sbeller@google.com>
Date
Jan 21, 2015, 01:21 UTC
Message-ID
<CAGZ79kZax5cyVy=uZq8eKLM0+FXDjOF1LS+_tkN4sbX0+HsUjQ@mail.gmail.com>
In-Reply-To
<1421803255-4037-1-git-send-email-sbeller@google.com>
On Tue, Jan 20, 2015 at 5:20 PM, Stefan Beller <sbeller@google.com> wrote:
Show 36 quoted lines
> Test if we can do arbitrary large transactions. Currently this is a known
> bug that we cannot do large transactions, so document it at least in the
> test suite.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  t/t1400-update-ref.sh | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh
> index 6805b9e..a7dd1ff 100755
> --- a/t/t1400-update-ref.sh
> +++ b/t/t1400-update-ref.sh
> @@ -1065,4 +1065,31 @@ test_expect_success 'stdin -z delete refs works with packed and loose refs' '
>         test_must_fail git rev-parse --verify -q $c
>  '
>
> +run_with_limited_open_files () {
> +       (ulimit -n 64 && "$@")
> +}
> +
> +test_lazy_prereq ULIMIT 'run_with_limited_open_files true'
> +
> +test_expect_failure ULIMIT 'large transaction creating branches does not burst open file limit' '
> +(
> +       for i in $(seq 65)
> +               echo "create refs/heads/$i HEAD"
> +       done >large_input &&
> +       git update-ref --stdin <large_input &&
> +       git rev-parse --verify -q refs/heads/65
> +)
> +'
> +
> +test_expect_failure ULIMIT 'large transaction deleting branches does not burst open file limit' '
> +(
> +       for i in $(seq 33)
This should be 65 of course. :/
Show 12 quoted lines
> +       do
> +               echo "delete refs/heads/$i HEAD"
> +       done >large_input &&
> +       git update-ref --stdin <large_input &&
> +       test_must_fail git rev-parse --verify -q refs/heads/65
> +)
> +'
> +
>  test_done
> --
> 2.2.1.62.g3f15098
>
Previous: Stefan Beller
Message 2 of 2 in “update-ref: Handle large transactions properly”
  1. update-ref: Handle large transactions properlyStefan Beller, Jan 21, 2015
  2. Stefan BellerJan 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.