Re: [PATCH 2/3] builtin/fetch: parse recurse-submodules-default at default options parsing

From: Stefan Beller <sbeller@google.com>
Date: Jun 27, 2017, 03:00 UTC
Message-ID: <CAGZ79kZUkQCEEcLUcg8tSr33Wng1Fq4_i4n80+Xr45y0mcvB6A@mail.gmail.com>
In-Reply-To: <xmqq1sqab436.fsf@gitster.mtv.corp.google.com>

On Fri, Jun 23, 2017 at 5:51 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

>>>>       if (recurse_submodules != RECURSE_SUBMODULES_OFF) {
>>>> -             if (recurse_submodules_default) {
>>>> -                     int arg = parse_fetch_recurse_submodules_arg("--recurse-submodules-default", recurse_submodules_default);
>>>> -                     set_config_fetch_recurse_submodules(arg);
>>>> -             }
>>>> +             if (recurse_submodules_default != RECURSE_SUBMODULES_DEFAULT)
>>>> +                     set_config_fetch_recurse_submodules(recurse_submodules_default);
>>>

>
> I am not talking about the outer "if" condition.

I agree with your analysis, my answer was evasive. I'll dig into the details why we do not set the default by default.