Re: [PATCHv7 0/8] Expose submodule parallelism to the user

From: Stefan Beller <sbeller@google.com>
Date: Jan 12, 2016, 23:59 UTC
Message-ID: <CAGZ79kZO=qLXK=tDt=DT=9og=aNgxk+ukoO4e5qDT=OAJCCS2A@mail.gmail.com>
In-Reply-To: <xmqqoacqs6g7.fsf@gitster.mtv.corp.google.com>

On Tue, Jan 12, 2016 at 3:50 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 36 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> This is a resend of sb/submodule-parallel-update and is available
>> at github[1] as well.  It applies on top of
>> sb/submodule-parallel-fetch
>>
>> What does it do?
>> ---
>> This series should finish the on going efforts of parallelizing
>> submodule network traffic. The patches contain tests for
>>   clone
>>   fetch
>>   submodule update
>> to use the actual parallelism both via command line as well as a
>> configured option. I decided to go with "submodule.fetchJobs" for
>> all three for now.
>>
>> What changed to v5,6?
>> ---
>> No major changes, I just made it compile again as the order of parameters
>> to the parallel processing engine changed.
>
> OK, I am in the process of replacing it but I am also rewinding
> 'next' and updating 'maint' today, so this update may not be
> published until tomorrow's integration cycle.
>
> Here are the changes I noticed, just to double check:
>
>  - There is no change in [1-3/8] relative to the previous round;
>    I'll keep the one that has been in my tree to preserve their
>    committer/author dates.
>
>  - In the log message of [4/8], the misspelt "submodule.jobs" in the
>    previous round now reads "submodule.fetchJobs".
>
>  - There is no change in [5-8/8] relative to the previous round.

Yeah that's it.

Additionally to that I needed to switch the order of arguments for the parallel processing calls, too, to make it compile again. I assume I just did that work twice as the previous version ought to compile, too.

But apart from these 2 things I did no other changes.

>
> Thanks.