git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule: use cheaper check for submodule pushes

From
Stefan Beller <sbeller@google.com>
Date
Jul 13, 2017, 00:09 UTC
Message-ID
<CAGZ79kZMVXR_S7z=uFohOYXAJrpj=hRFn=w--EWiEEvxF3KCkw@mail.gmail.com>
In-Reply-To
<20170713000117.GJ93855@aiede.mtv.corp.google.com>
On Wed, Jul 12, 2017 at 5:01 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> These footnotes don't answer the question that I really have: why did
> this use add_submodule_odb in the first place?

oh, I forgot to put that down: presumably add_submodule_odb was used because it was available back then? Note the dates!

> E.g. did the ref iteration code require access to the object store
> previously and stop requiring it later?
No. See [1], it was overkill since the beginning of time.
Show 7 quoted lines
>> -     if (add_submodule_odb(path))
>> +     int code;
>> +
>> +     if (!is_submodule_populated_gently(path, &code))
>
> Should this examine the code to distinguish between hard errors
> (e.g. "Error reading .git") and a missing repository?

add_submodule_odb does neither, so I think this is best kept without additional checks.

Thanks!
Previous: Jonathan NiederNext: Junio C Hamano
Message 3 of 20 in “submodule: use cheaper check for submodule pushes”
  1. submodule: use cheaper check for submodule pushesStefan Beller, Jul 12, 2017
  2. Jonathan NiederJul 13, 2017
  3. Stefan BellerJul 13, 2017
  4. Junio C HamanoJul 13, 2017
  5. Stefan BellerJul 13, 2017
  6. Junio C HamanoJul 13, 2017
  7. Stefan BellerJul 13, 2017
  8. Jonathan NiederJul 13, 2017
  9. Stefan BellerJul 13, 2017
  10. push: do not add submodule odb as an alternate when recursing on demandStefan Beller, Aug 15, 2017
  11. Jonathan NiederAug 15, 2017
  12. Jonathan NiederAug 15, 2017
  13. Stefan BellerAug 15, 2017
  14. Junio C HamanoAug 15, 2017
  15. Stefan BellerAug 15, 2017
  16. Junio C HamanoAug 16, 2017
  17. Stefan BellerAug 16, 2017
  18. Jonathan NiederAug 16, 2017
  19. Stefan BellerAug 16, 2017
  20. Heiko VoigtAug 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.