Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email
- From
Stefan Beller <sbeller@google.com>
- Date
- Dec 9, 2016, 23:56 UTC
- Message-ID
- <CAGZ79kZKify7VLfNp3FXXvc4UOGjdXfUaspNaeW0t5+hWc+cpw@mail.gmail.com>
- In-Reply-To
- <xmqqshpwpsn8.fsf@gitster.mtv.corp.google.com>
On Fri, Dec 9, 2016 at 3:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Stefan Beller <sbeller@google.com> writes: > >> So you are suggesting to >> * have the check later in the game (e.g. just after asking >> "Send this email? ([y]es|[n]o|[q]uit|[a]ll): " as then other information >> such as additional @to @cc are available. > > Yeah, probably before the loop starts asking that question for each > message. And hook does not necessarily need to cause the program to > die. The question can be reworded to "Your hook says no, but do you > really want to send it?",
You could, but that would be inconsistent with the "*** SUBJECT ***" treatment, which currently dies. That could also ask "do you really want to send out an unfinished series" and continue if the user wants.
I assume we want to be consistent with the existing UI and just ask the user to use force instead?