Re: [PATCH] doc: clarify distinction between sign-off and pgp-signing

From: Stefan Beller <sbeller@google.com>
Date: Jan 27, 2017, 21:01 UTC
Message-ID: <CAGZ79kZHLyFJ-OWd9R=g3hZs6mhRfGGe_=zG+ZiBkR5B-L-iqA@mail.gmail.com>
In-Reply-To: <01fc4c33-2d4e-e19f-d447-6a187e15d2ed@tngtech.com>

On Fri, Jan 27, 2017 at 12:48 PM, Cornelius Weig <cornelius.weig@tngtech.com> wrote:

Show 5 quoted lines

>>
>> So maybe s/signed-off-by/helped-by/?
>>
>
> This is getting real complex :-/

uh; sorry for that. I do not mind the patch as posted, just in case you reroll for another reason, this is worth thinking about.

In fact, as said before I like that patch.

Show 9 quoted lines

>
> As I said in the notes for the patch:
>
>>>     As I don't know what is appropriate, I took the liberty to add everybody's
>>>     sign-off who was involved in the discussion in alphabetic order.
>
> With your explanation, I guess the most accurate sign-off chain would be:
>
> Signed-off-by: Stefan Beller <sbeller@google.com> (as you sent a patch)

...and here we could continue arguing. ;) Is the patch I sent note-worthy enough to be deriving work from? My gut reaction would be "no".

> Helped-by: Philip Oakley <philipoakley@iee.org> (no patch, but helpful)
> Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com> (this patch)
> Signed-off-by: Junio C Hamano <gitster@pobox.com> (once he decides it's good)