Re: [PATCH 01/12] git submodule update: Announce skipping submodules on stderr

From: Stefan Beller <sbeller@google.com>
Date: Oct 16, 2015, 20:47 UTC
Message-ID: <CAGZ79kZH1sdboAzFCjAUKtg0sJcPZGjzVrHPa_r8dG4bK4uT-w@mail.gmail.com>
In-Reply-To: <xmqqbnbyeei6.fsf@gitster.mtv.corp.google.com>

On Fri, Oct 16, 2015 at 1:37 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>  git-submodule.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/git-submodule.sh b/git-submodule.sh
>> index 8b0eb9a..578ec48 100755
>> --- a/git-submodule.sh
>> +++ b/git-submodule.sh
>> @@ -684,7 +684,7 @@ cmd_update()
>>
>>               if test "$update_module" = "none"
>>               then
>> -                     echo "Skipping submodule '$displaypath'"
>> +                     echo >&2 "Skipping submodule '$displaypath'"
>>                       continue
>>               fi
>
> Makes sense, but see 02/12.

The patch (I can't see a reply there) ?

I split them on purpose. This one uses echo as opposed to say and has no tests to fail.

So this patch documents, that there are no breaking tests. I can just change it 2/12 tells another story: We codified the behavior in tests and rely on it, so we need to carefully decide if that's a breaking change.