Re: [PATCH v2 2/8] t7004: rename ULIMIT test prerequisite to ULIMIT_STACK_SIZE

From: Stefan Beller <sbeller@google.com>
Date: May 11, 2015, 17:23 UTC
Message-ID: <CAGZ79kZFC3Qr-S5dxHFf3W6FF6miNcbD8qCD48fP=PqzDhf75Q@mail.gmail.com>
In-Reply-To: <1431225937-10456-3-git-send-email-mhagger@alum.mit.edu>

On Sat, May 9, 2015 at 7:45 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:

Show 5 quoted lines

> From: Stefan Beller <sbeller@google.com>
>
> During creation of the patch series our discussion we could have a
> more descriptive name for the prerequisite for the test so it stays
> unique when other limits of ulimit are introduced.

I must have had a bad day when trying to write this. Either words are missing (just insert a "revealed" after discussion on the first line) or it doesn't make any sense. How about:

In this patch series we introduce another test depending on a different ulimit so we need to have a more descriptive name for this prerequisite such that it stays unique when other limits of ulimit are introduced.

Show 27 quoted lines

>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  t/t7004-tag.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index 796e9f7..06b8e0d 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -1463,10 +1463,10 @@ run_with_limited_stack () {
>         (ulimit -s 128 && "$@")
>  }
>
> -test_lazy_prereq ULIMIT 'run_with_limited_stack true'
> +test_lazy_prereq ULIMIT_STACK_SIZE 'run_with_limited_stack true'
>
>  # we require ulimit, this excludes Windows
> -test_expect_success ULIMIT '--contains works in a deep repo' '
> +test_expect_success ULIMIT_STACK_SIZE '--contains works in a deep repo' '
>         >expect &&
>         i=1 &&
>         while test $i -lt 8000
> --
> 2.1.4
>